Derive multisig ownership history based on past transactions and latest discovery output #103
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
sdlyy
changed the title
michalsidzej
suggested changes
Jan 4, 2024
Comment on lines
+151
to
+152
| (ownerModification.decoded?.method === 'addOwnerWithThreshold' || | ||
| ownerModification.decoded?.method === 'removeOwner') && |
There was a problem hiding this comment.
I think we also need the function changeThreshold here
There was a problem hiding this comment.
We ain't need threshold since whenever transactions was successfully executed, we assume quorum has been reached
There was a problem hiding this comment.
We're only recreating owner's amount history
michalsidzej
reviewed
Jan 4, 2024
Comment on lines
+147
to
+149
| const ownerChangingTransactions = allTransactions | ||
| .map((tx) => ({ raw: tx, decoded: getDecodedProperties(tx) })) | ||
| .filter( |
There was a problem hiding this comment.
Are we sure that all the transactions here have been executed?
There was a problem hiding this comment.
That's exactly the purpose of line ~153, where we filter only executed transactions
|
Up 'n Down Ignoring discarded txs: |
sdlyy
force-pushed
the
feat/include-variable-owners-within-tx
branch
from
ae75767
to
8593445
Compare
sdlyy
force-pushed
the
feat/include-variable-owners-within-tx
branch
from
8593445
to
5aa2111
Compare
michalsidzej
approved these changes
Jan 9, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves L2B-3124
What's changed
Ownership history is derived from internal multi-sig transactions.
I reorganized a few things, but nothing breaking was introduced.
Notes
We could fire
getDecodedPropertiesonly once, now we do that in2 * amount of txsmanner. We ain't need optimizations for now